Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugin: cherrypick fix for segfault on empty XDG_DATA_DIR #204740

Merged
merged 1 commit into from Dec 10, 2022
Merged

hugin: cherrypick fix for segfault on empty XDG_DATA_DIR #204740

merged 1 commit into from Dec 10, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 6, 2022

Description of changes

Hugin segfaults if the environment variable XDG_DATA_DIR is unset (rather than being the empty string). Upstream has committed a fix in edfddc6070ca6d4223d359fb4b38273a5aed2f2d but has not released it (hugin releases are very infrequent).

Let's cherry-pick the fix since it might be a while before they manage another release.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

hugin: cherrypick fix for segfault on empty XDG_DATA_DIR
ccdfaa8 
Hugin segfaults if the environment variable XDG_DATA_DIR is unset
(rather than being the empty string).  Upstream has committed a fix
in edfddc6070ca6d4223d359fb4b38273a5aed2f2d but has not released it
(hugin releases are *very* infrequent).

Let's cherry-pick the fix since it might be a while before they
manage another release.
@ofborg ofborg bot requested a review from hrdinka December 6, 2022 06:45
@Artturin Artturin merged commit 790020f into NixOS:master Dec 10, 2022
@ghost ghost deleted the hugin1 branch January 1, 2023 22:37
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrdinka hrdinka Awaiting requested review from hrdinka

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Artturin